Closed kmonticolo closed 4 years ago
FYI Having merge commits in PR is generally considered bad practice. Also merging master into master is something you usually do not want to do.
FYI you should probably take the search engine of your choice and learn how to rebase, edit commits and force push. There was no need to close this PR and open a new one.
FYI Having merge commits in PR is generally considered bad practice. Also merging master into master is something you usually do not want to do.