search

kahypar / mt-kahypar

Mt-KaHyPar (Multi-Threaded Karlsruhe Hypergraph Partitioner) is a shared-memory multilevel graph and hypergraph partitioner equipped with parallel implementations of techniques used in the best sequential partitioning algorithms. Mt-KaHyPar can partition extremely large hypergraphs very fast and with high quality.
MIT License
122 stars 25 forks source link

use mini_boost target #177

Closed juliannz closed 2 months ago

juliannz commented 10 months ago

When you use the KAHYPAR_DOWNLOAD_BOOST cmake option without an existing boost installation (what seems to be the intended use case to me), cmake fails afterwards because Boost::program_options is not found.

With these changes, this is fixed. As a side effect, the download option now precedes both existing installations and the disable option introduced in #170.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d784c91) 78.90% compared to head (7cb735f) 78.83%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #177 +/- ## ========================================== - Coverage 78.90% 78.83% -0.08% ========================================== Files 202 202 Lines 19632 19632 Branches 8036 8036 ========================================== - Hits 15490 15476 -14 - Misses 4142 4156 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

juliannz commented 2 months ago

When I download the latest master branch and try to use KAHYPAR_DOWNLOAD_BOOST I still run in the same issue and the proposed changes still fix the issue, so did the desired behaviour concerning the precedence of multiple installed versions change in the meantime? And I didn't find any merge conflicts either...

Rereading the thread of #170, I think you may expect this PR to include the change proposed in my comment but this is not the case. Should I include it?

N-Maas commented 2 months ago

Rebased to re-trigger the CI. Should be fine to merge when the CI completes