search

kai-oswald / ASE

URL Shortener built with NodeJS
http://localhost:8001
MIT License
3 stars 0 forks source link

Current Status. Have to check it #60

Closed DTobii closed 7 years ago

DTobii commented 7 years ago

Please review both files with the sources we get at moodle (mail)!

DTobii commented 7 years ago

Added additional classdiagramm. What do you say? Something missing? URL Okay?

Hurba commented 7 years ago

I would change the layout of the assossiations. Put the number next to the belonging box. By doing this you can delete the name near the number. In addition i would seperate the lines between model or routes and the controller.

kai-oswald commented 7 years ago

I agree with @Hurba. But by definition we need to use an assoication name. Maybe use some better names than "kennt".

mlechler commented 7 years ago

I agree with @Hurba and @kai-oswald

But @DTobii, why the hell don't you use the naming-convention for new branches.

TrAnn3l commented 7 years ago

I agree with @Hurba and @kai-oswald Especially i agree with @mlechler, @DTobii use the naming-convention!

DTobii commented 7 years ago

Then make a proposal for better names @kai-oswald

kai-oswald commented 7 years ago

clockwise:

If we need to use english names, please use the corresponding translations.