kaicataldo / material.vim

🎨 A port of the Material color scheme for Vim/Neovim
MIT License
610 stars 71 forks source link

iterm2 vim 8.1 color weird #40

Closed docoder closed 4 years ago

docoder commented 4 years ago

1583801589899

docoder commented 4 years ago

iterm2 3.3.9

kaicataldo commented 4 years ago

I am unable to reproduce this with the same versions of iTerm2 and Vim. Some follow-up questions:

  1. Are you using tmux?
  2. Have you tried finding the minimal repro case by removing other things in your Vim config?
reidcooper commented 4 years ago

I am encountering this issue.

Deleted all plugins and re-installed them.

VIM - Vi IMproved 8.1 (2018 May 18, compiled Dec 13 2019 14:45:40)
Included patches: 1-503, 505-680, 682-1312

No tmux - same results though. iTerm 2 Build 3.3.9

Screenshot 2020-03-17 14 35 28
kaicataldo commented 4 years ago

Since I'm unable to reproduce, would appreciate if someone could figure out repro steps.

reidcooper commented 4 years ago

I reinstalled iTerm and Vim. Didn't fix it.

But I nuked my ~/.vim directory and started over which solved the problem for me.

I had a feeling it was something to do with vim-plug but I have no idea.

Thanks. My issue has been solved.

gko commented 4 years ago

@reidcooper can you make a repo with working config?

gko commented 4 years ago

here is my example config: https://github.com/gko/vimrc-material-example

works perfectly with neovim

but for some reason not with vim (iterm or terminal)

tried both importing colors into iterm and without importing them.

docoder commented 4 years ago

.zshrc add alias vim='/Applications/MacVim.app/Contents/MacOS/Vim' fixed it

docoder commented 4 years ago

vim version 8.2.319

gko commented 4 years ago

vim in macOS doesn't support termguicolors.

So there are three options:

  1. update vim to 8.2 and get the support in iTerm 2
  2. add cterm support in color theme (added draft #41)
  3. check for termguicolors support and set a fallback theme like here: https://github.com/gko/vimio/blob/master/.vimrc_background#L17-L27
kaicataldo commented 4 years ago

Please see the readme. Information about true colors can be found here.

gko commented 4 years ago

@kaicataldo I know, I just summed it up for the people that will come across this issue

kaicataldo commented 4 years ago

Thanks, appreciated :)

kaicataldo commented 4 years ago

Closing since this has been resolved.