search

kaichaosun / rlt

Localtunnel implementation in Rust, expose local API to the public.
MIT License
87 stars 11 forks source link

Docker support #28

Closed Krystex closed 1 year ago

Krystex commented 1 year ago

Hello @kaichaosun! Thank you for your awesome project.

I mostly use Docker at home, so I built a docker container for your project. Today or tomorrow I will add instructions how to run it.

Krystex commented 1 year ago

@kaichaosun, what would you think of extending the CLI with an option to bind the server at a custom ip? By default, your app binds on 127.0.0.1, but for the docker container it would be better to bind on all interfaces (0.0.0.0).

kaichaosun commented 1 year ago

Hey @Krystex, the ip can be set with CLI parameter, check here, or do I misunderstood your idea with extending the CLI?

Change the default binding to 0.0.0.0 sounds great!

Krystex commented 1 year ago

Sorry I should clarify, I'm talking about the server, not the client. It seems like the binding to 127.0.0.1 is hardcoded, see here and here

kaichaosun commented 1 year ago

Ah, I see. Extend the server CLI parameter seems not necessary to me, since only 0.0.0.0 or 127.0.0.1 will be used here.

kaichaosun commented 1 year ago

thanks for your contribution!