search

kaichaosun / rlt

Localtunnel implementation in Rust, expose local API to the public.
MIT License
93 stars 11 forks source link

Add a flag to set the connection count or reduce logging spam #9

Closed alextes closed 2 years ago

alextes commented 2 years ago

This is kinda subjective, perhaps we can wait and see if others agree, but I expect most users need just one proxied connection as they're doing development, where a flag to overwrite the connection count could be helpful, I'm guessing you yourself had a need for more connections for example.

kaichaosun commented 2 years ago

Yeah, have a configurable flag to set the max connection makes a lot sense. Have the default connection count set to be the one from localtunnel server seems better to make client and server consistent.

alextes commented 2 years ago

@kaichaosun by the way, I'm in no hurry for this to work! I just switched to using tunnelto, works well, but also costs money. I'd love for a solid rust tunneling library to exist to help devs. So I thought I'd still report what I'd need to be able to use this instead of other tools, but paying $2 / month for tunnelto is no big deal either in the meantime.

RE: default matching the localtunnel server, that makes total sense! 👍 I guess it would also work to just put those logs on the debug level or something so the user normally doesn't see or worry about them. Thinking on it more, what do I care if there are 1 or 10 connections if that's what the localtunnel server wants.