search

kaiiiz / hugo-theme-monochrome

Monochrome is a fast, clean and responsive hugo theme
https://kaiiiz.github.io/hugo-theme-monochrome/
MIT License
171 stars 52 forks source link

Navbar menu links have margin between text and underline #15

Closed Nightfirecat closed 11 months ago

Nightfirecat commented 2 years ago

Refer to screenshot of li.navbar-item.pure-menu-item: (containing a.pure-menu-link)

When I encountered this theme, I was surprised that it was possible to hover the list item and cause the bottom border to appear without being able to click on the link contained within it. I would expect the vertical space between them to be clickable. (including the border, ideally) On other sites, I see this achieved by applying little-to-no styling on the list items, instead opting to style the <a>s contained within to ensure all padding and borders are clickable.

kaiiiz commented 2 years ago

Thank for pointing out the issue. You're right. Adding style to <a> should be better than adding it to the list item. I'll fix it and it'll be available in the next release.

kaiiiz commented 11 months ago

Fixed in v2.0.0.