search

kaiiyer / webtech

Identify the technologies used on websites. (Dig-deep into web tech from your terminal)
GNU Lesser General Public License v3.0
49 stars 39 forks source link

Available options in webtech #40

Closed Tawishi closed 4 years ago

Tawishi commented 4 years ago

This is a part of the documentation. Please review and convey the necessary changes.

kaiiyer commented 4 years ago

Please review and suggest necessary changes.

The checks have failed. You can improve the quality of the PR. Look here for details Suggestion: Don't use space bars while naming a file. Use _ instead. It'll help you in future !

kaiiyer commented 4 years ago

Sir, I have made the necessary changes. Please review.

Still the checks are failing as you can see. I suggest you take help from @utkarsh-raj and @koderjoker !

utkarsh-raj commented 4 years ago

Hey @Tawishi did you check the details of why the tests are failing?

koderjoker commented 4 years ago

@Tawishi if you click on "Details" on the right of the Codacy/PR Quality Review, you can see the list of issues explaining why your checks are failing.

If you're stuck on solving one of the issues, let us know so that we can walk through them one by one!

Tawishi commented 4 years ago

@Tawishi if you click on "Details" on the right of the Codacy/PR Quality Review, you can see the list of issues explaining why your checks are failing.

If you're stuck on solving one of the issues, let us know so that we can walk through them one by one!

Sir, I have tried solving the issues but the checks still fail.

Screenshot from 2020-03-07 19-56-00

utkarsh-raj commented 4 years ago

Looks like you are trying to make a markdown file @Tawishi . You can check the correct syntax for writing markdown. A cursory reading of the error logs show that the md you are using does not support HTML syntax. Maybe try a workaround?

Tawishi commented 4 years ago

@Tawishi if you click on "Details" on the right of the Codacy/PR Quality Review, you can see the list of issues explaining why your checks are failing.

If you're stuck on solving one of the issues, let us know so that we can walk through them one by one!

This is what the suggested solution is. How should I proceed ?

Screenshot from 2020-03-14 10-40-43

kaiiyer commented 4 years ago

@utkarsh-raj @koderjoker Just see to it !

koderjoker commented 4 years ago

@Tawishi let's go through the issues which are causing your pr to fail one by one.

The first issue: Screen Shot 2020-03-14 at 3 19 33 PM

This issue asks you to change the file name of the file you are adding, such that it doesn't contain an underscore ("_").

The name of the file you are adding is "Available_Options.md". Could you change the name of the file that you are adding to the repository, such that it fulfils this requirement?

Tawishi commented 4 years ago

@Tawishi let's go through the issues which are causing your pr to fail one by one.

The first issue: Screen Shot 2020-03-14 at 3 19 33 PM

This issue asks you to change the file name of the file you are adding, such that it doesn't contain an underscore ("_").

The name of the file you are adding is "Available_Options.md". Could you change the name of the file that you are adding to the repository, such that it fulfils this requirement?

Ok,sir.

Tawishi commented 4 years ago

@Tawishi let's go through the issues which are causing your pr to fail one by one. The first issue: Screen Shot 2020-03-14 at 3 19 33 PM This issue asks you to change the file name of the file you are adding, such that it doesn't contain an underscore ("_"). The name of the file you are adding is "Available_Options.md". Could you change the name of the file that you are adding to the repository, such that it fulfils this requirement?

Ok,sir.

Done.