search

kaiiyer / webtech

Identify the technologies used on websites. (Dig-deep into web tech from your terminal)
GNU Lesser General Public License v3.0
49 stars 39 forks source link

Add git actions workflow #45

Closed kaiiyer closed 4 years ago

kaiiyer commented 4 years ago

Workflow 1: Integrating Slack with Github for notifications Workflow 2: Add workflow for testing the code on every push operation

keshakaneria commented 4 years ago

Can i work on this issue and assign me, as i am solving the previous issue, which involves workflows so i am working on this too @kaiiyer

kaiiyer commented 4 years ago

Can i work on this issue and assign me, as i am solving the previous issue, which involves workflows so i am working on this too @kaiiyer

Yeah go ahead !

keshakaneria commented 4 years ago

Should i name the files as workflow 1 and 2 or edit the slack.yml file which i opened the PR #43 earlier? @kaiiyer

kaiiyer commented 4 years ago

leave the slack workflow as it as. Create a new file named anything.yml and submit a PR

keshakaneria commented 4 years ago

So basically it should have testing code right? (explain the issue briefly) because workflow 1 is comprised in slack.yml

kaiiyer commented 4 years ago

Workflow 1 is completed. So don't worry about it. For workflow 2: Whenever we update the code(pushing new commits or PRs) it should check for errors. Like mypy -finding bugs in the program without even running it !

kaiiyer commented 4 years ago

@keshakaneria Since you're working on this. Adding a travis integration would be easier for you. So if you want you can take up issue #22 too !

keshakaneria commented 4 years ago

Okay, commented on that issue, if anyone isnt working on it do assign me