kaiiyer / webtech

Identify the technologies used on websites. (Dig-deep into web tech from your terminal)
GNU Lesser General Public License v3.0
48 stars 39 forks source link

Beautiful Soup Scraping Script #47

Closed aayush1205 closed 4 years ago

aayush1205 commented 4 years ago

Added bs4 script to scrape general information of a given website. The script is easy to extend, other people can add more functionalities if needed. Also had to add into the requirements.txt.

aayush1205 commented 4 years ago

@utkarsh-raj Is it fine now, sir?

aayush1205 commented 4 years ago

Um, @kaiiyer would you please merge it? I think utkarsh isn't available right now.

kaiiyer commented 4 years ago

Okay !

aayush1205 commented 4 years ago

19 can be closed now.

aayush1205 commented 4 years ago

@kaiiyer Thank you so much!!

kaiiyer commented 4 years ago

@aayush1205 look at the errors. Modify your code, Test it locally. Submit a new PR with the working Screenshot and make sure you make your changes in a new branch !

aayush1205 commented 4 years ago

@kaiiyer #49 fixes the errors. You might want to check.

kaiiyer commented 4 years ago

Upload a ScreenShot of the script working in your local environment !

aayush1205 commented 4 years ago

Here, @kaiiyer

Screenshot from 2020-03-12 11-15-43

kaiiyer commented 4 years ago

Okay cool !

kaiiyer commented 4 years ago

The command python3 -m webtech -s https://app.codacy.com/ is working but look at this @aayush1205 image

aayush1205 commented 4 years ago

Should not happen really. Can you give me steps to reproduce error.

kaiiyer commented 4 years ago

Just type the same command

aayush1205 commented 4 years ago

OkAy. Give me a bit. I'll check and let you know. So sorry this happened.

kaiiyer commented 4 years ago

Take your time. As soon as you fix this, we'll close the issue !

aayush1205 commented 4 years ago

Hey, @kaiiyer, it's working with the following command: python3 -m webtech -s website

Since the directory has the main and init.py, after running python3 -m, the interpreter runs the main.py which henceforth adds the -s argument.

kaiiyer commented 4 years ago

Yeah I've seen that it's working with python -m webtech command. But it isn't working with webtech -s command

aayush1205 commented 4 years ago

Yes @kaiiyer that's the point. Until and unless main doesn't run, how will it pick up on the scrape argument.

Ref : https://shaneoneill.io/2019/06/12/use-__main__-py/

kaiiyer commented 4 years ago

Oh got it ! I'm closing the issue