search

kaijagahm / vultureUtils

Utility functions for working with vulture data
Other
4 stars 0 forks source link

Fix sloppy argument passing (e.g. idCol) #58

Open kaijagahm opened 1 year ago

kaijagahm commented 1 year ago

Currently I think the arguments like idCol etc are hidden in supporting functions and aren't actually accessible to the user e.g. in getEdges. Either just remove those and make it clear what names are expected, or actually make those arguments accessible.

The latter would be preferable, since the architecture is already there to do it, but the former might need to fly.

kaijagahm commented 1 year ago

Another example: passing of idCol to mostlyInMask. Had to add an idCol arg to mostlyInMask, and then explicitly declare it when mostlyInMask is called in cleanData. This seems sloppy. There's got to be a better way.