Fix wrong return type in DataSet.join() overload

kaiko-ai / typedspark

Column-wise type annotations for pyspark DataFrames

Apache License 2.0

65 stars 4 forks source link

Fix wrong return type in DataSet.join() overload #118

Closed nanne-aben closed 1 year ago

nanne-aben commented 1 year ago

Consider the following example:

a: DataSet[A]
b: DataSet[B]

res1: DataSet[A] = a.join(b, A.a == B.b, how="semi")
res2: DataFrame = a.join(b, A.a == B.b, how="left"))
res3: DataFrame = a.join(b, A.a == B.b)

Currently, due to a wrongly defined @overload, res3 is actually a DataSet[A]. This PR fixes that behaviour.