nus-se-script
commented
3 weeks ago Team's Response
Thank you for the bug report! We are rejecting this issue because of the following reasons:
- When using the add command, our app detects duplication based on having the same email OR phone number OR Telegram handle. Hence, even if the names are the same, it would not be considered duplicate as two people of the same name could very much be two different people which our app has taken into for consideration when building this feature.
- Given that, it is unnecessary for our app to consider consecutive whitespaces in the name.
Hence, this is expected behavior, and not a bug at all.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: I would have to disagree that this is an "expected behaviour" of the app. Firstly, we all know that the presence of consecutive whitespaces in the Names of People make absolutely no sense at all, as reflected in the real world, it is either one whitespace or none. Given that fact, it is completely up to the developer team to recognise this and match this input validation with what happens in the real world. In real world applications, if you have consecutive whitespaces in your Name, it is either trimmed and reflected in the application or it is not allowed. Having consecutive whitespaces in the Name of a person is not just as simple as having another person with the same Name.
Secondly, regarding the duplicate detection of the contacts by Telegram/Phone/Email, because of the consecutive whitespaces in the Name, it is entirely possible for a user to type in a person's name e.g. "Amy Tan" with no whitespace, but with a valid Email address and nothing else, and type in another person with "Amy Tan" (with consecutive whitespaces, Catcher automatically trims the whitespace I realise), and fill in the Phone number with no email and no telegram/nothing else. Therefore, we would have 2 Amy Tan's, 1 with Email, and another 1 with Phone number, while their names differ by a consecutive whitespace. It is entirely possible that the user intended for these 2 Amy Tan's to be the same person, as the user may have forgotten that he/she has input an Amy Tan before that and made a typo of a consecutive whitespace. Note that because of the 'OR' validation of Telegram/Phone/Email, this makes it impossible to differentiate that these 2 people are different people, as the user can enter these optional fields separately. Thus these 2 Amy Tan's are the same person and the phone and email belong to the same person, just that the phone and email is in 2 different contacts ("Amy Tan" with no consecutive whitespace, and "Amy Tan" with consecutive whitespace) in the addressbook.
Hence, this would lead to insufficient duplicate detection.
Referring to the image above, when I add a person "John Doe" with only his telegram handle, and then I add another person "John Doe" with an extra whitespace in between the names, and I don't input his telegram handle, but instead put his email. The app allows this to pass through without any warning, and in the course website, it states that this could be a possible feature flaw as the user may have typed in a consecutive extra white space in between the "John Doe" name.
Steps to reproduce: create person with name "John Doe" and another one with "John Doe" with 2 consecutive white spaces.