search

kaikramer / keystore-explorer

KeyStore Explorer is a free GUI replacement for the Java command-line utilities keytool and jarsigner.
https://keystore-explorer.org/
GNU General Public License v3.0
1.7k stars 275 forks source link

Typo in line #126

Closed snarkbe closed 6 years ago

snarkbe commented 6 years ago

https://github.com/kaikramer/keystore-explorer/blob/502a9611b254b181abc564444537489b6879d2e5/kse/src/org/kse/crypto/filetype/CryptoFileUtil.java#L236

Is 251 a typo, or is it really the new value? It doesn't match the comment.

kaikramer commented 6 years ago

Hehe, that actually looks like a mistake at first glance. 😄 But that's not the number "1" at the end, it's the letter "l", because DataInputStream.skip() gets the number of bytes to be skipped passed as a long value. So it skips 25 bytes (21 + 4) as explained in the comment.