search

kaikramer / keystore-explorer

KeyStore Explorer is a free GUI replacement for the Java command-line utilities keytool and jarsigner.
https://keystore-explorer.org/
GNU General Public License v3.0
1.7k stars 275 forks source link

Allow to select multiple entries and copy/paste or delete them #219

Closed ChristophKaser closed 4 years ago

ChristophKaser commented 4 years ago

This PR allows users to select more than one entry in the keystore table (by pressing SHIFT or CTRL).

The following operations are supported for multiple entries:

kaikramer commented 4 years ago

That's certainly one of the most missed features. Thanks for tackling it, much appreciated! I'll do the review on the weekend.

kaikramer commented 4 years ago

It's working great and the code is fine as well. I have found just one little issue:

Let's say there are several key pairs (or a mixture of certificates and keys) in a keystore and you ...

  1. select all of them
  2. do a Ctrl-C to copy them
  3. enter the password for the first key or key pair then only the first entry is selected afterwards. Not a big deal, but unexpected.
ChristophKaser commented 4 years ago

Great catch, this was caused by KseFrame.updateControls, which tried to restore the selection, but did not handle multiple selected rows. I added a commit addressing the problem to the PR.

kaikramer commented 4 years ago

Thanks again!

ChristophKaser commented 4 years ago

Thank you for merging!