search

kaikramer / keystore-explorer

KeyStore Explorer is a free GUI replacement for the Java command-line utilities keytool and jarsigner.
https://keystore-explorer.org/
GNU General Public License v3.0
1.69k stars 272 forks source link

GUI - Minor issue on icon of the `Display ASN.1 dump` windows #352

Closed The-Lum closed 1 year ago

The-Lum commented 2 years ago

1. Minor issue on icon of the Diplay ASN.1 dump windows

Describe the bug On the Display ASN.1 dump windows, we observe the icon of the Java JRE, and not the icon of KSE,

To Reproduce Steps to reproduce the behavior:

  1. Select a 'KeyPair' or a 'Cert'
  2. Click on 'ASN.1' button
  3. See error

Expected behavior Like for all the other windows, see the same KSE icon.

Screenshots

2022-02-05_DisplayASN1

2. During search, on the same topic, I had some question...

What is the meaning of the icon genkp.png (similar to the KSE icon):

Only use 2 times: https://github.com/kaikramer/keystore-explorer/blob/dab085174bcc3d67dc115742e0cf421df17ba3ef/kse/src/org/kse/gui/dialogs/DGeneratingKeyPair.java#L109-L111

https://github.com/kaikramer/keystore-explorer/blob/dab085174bcc3d67dc115742e0cf421df17ba3ef/kse/src/org/kse/gui/dialogs/DGeneratingDHParameters.java#L98-L100

Thanks for your answer, Regards.

Environment

kaikramer commented 2 years ago

  1. This icon comes from the Java runtime. For example with my Java 8 runtime there is no icon: grafik I will check if there is a way to disable it for all versions (or use the KSE icon).

  2. Not sure if I understood your question, but this icon shows a key pair (and yes it's the KSE application icon without the magnifying glass) and is used for two purposes: a. The "generating" key pair dialogs (as you have already found out): grafik b. The file types like .jks, .jceks and so on that are associated with KSE on installation get this icon in the Windows Explorer: grafik The icon was made by a professional designer exclusively for KSE together with the KSE application icon.

The-Lum commented 2 years ago

Hello @kaikramer,

Thanks a lot for your answers.

1/ FYI, here is another example, with Java 8 (with Oracle - jre1.8.0_152):

2022-02-07_DisplayASN1_onJava8

And the main question, will be now:

And thanks for:

I will check if there is a way to disable it for all versions (or use the KSE icon).

2/ Thanks for those precisions. I confused the 2 icons, which are very similar...

Regards.

kaikramer commented 2 years ago

Ok, I see. The application icon is set in KseFrame.java and should be used everywhere, but the ASN.1 dump window is a bit special... I'll take a closer look at it on the weekend, but I think I know how I can fix that.

kaikramer commented 2 years ago

What I have recently noticed is that the application icon is missing some times:

grafik