kaikramer / keystore-explorer

KeyStore Explorer is a free GUI replacement for the Java command-line utilities keytool and jarsigner.
https://keystore-explorer.org/
GNU General Public License v3.0
1.67k stars 271 forks source link

M1 support #366

Open orefalo opened 2 years ago

orefalo commented 2 years ago

Would be great to see the Mac app wrapper adjusted to support the M1 platform.

Thank you

orefalo commented 2 years ago

Well, if anyone is interested.

I got it working by following these instructions - https://www.youtube.com/watch?v=ZI3U4I2nK2s which uses this great project https://github.com/tofi86/universalJavaApplicationStub

You can download the modified universal binary from https://drive.google.com/file/d/195Xgv0NOR4-7ajgoFEE0dUsrfyxHsD5Y/view?usp=sharing

Cheers,

kaikramer commented 2 years ago

There will certainly be universal binary of KSE later this year. So far it just didn't have priority because KSE runs perfectly fine on M1 Macs (I actually own one).

The universalJavaApplicationStub project is very interesting. I can't use it in its current state, but as it is a simple bash script, I could modify it for my purposes. Thanks for the link!

sampl3x commented 2 years ago

Hoping to see a ARM version as well.

raydoom commented 1 year ago

Well, if anyone is interested.

I got it working by following these instructions - https://www.youtube.com/watch?v=ZI3U4I2nK2s which uses this great project https://github.com/tofi86/universalJavaApplicationStub

You can download the modified universal binary from https://drive.google.com/file/d/195Xgv0NOR4-7ajgoFEE0dUsrfyxHsD5Y/view?usp=sharing

Cheers,

Can not download,It say File is in owner's trash

orefalo commented 1 year ago

let me fix that. plz try again

raydoom commented 1 year ago

let me fix that. plz try again

Good jod, It works very well!

orefalo commented 1 year ago

Just assembled version KeyStore Explorer 5.5.2 for Arm, https://drive.google.com/file/d/1t_kpb1y-8ceAKNPyKtFS9vhpQgIbmBDf/view?usp=share_link

Really don't understand why the author doesn't come with a version, the bundling is trivial to do.

kaikramer commented 1 year ago

Really don't understand why the author doesn't come with a version, the bundling is trivial to do.

Priorities. There is no noticeable difference between the Intel and the Arm version of KSE, but it takes time away from me for integrating it in the build pipeline, that can be better used for stuff that is actually useful for a larger group of users.

Also, a quick reminder how Open Source works: If you want an official Arm version of KSE and think it is easy to do it, then just do it. All the files for building the macOS package are in this repo, you just have to adapt them.

I can guide you if necessary, tell you where the changes have to be made. But keep in mind that both code-signing and notarization of a bash script might be problematic and cross-compiling with shc on the GitHub runner won't work because of a bug in shc. I won't be able to help you with those issues.

orefalo commented 1 year ago

Those are all very good points @kaikramer Will allocate some time to review the build process and contribute to the official repo.

raydoom commented 1 year ago

Just assembled version KeyStore Explorer 5.5.2 for Arm, https://drive.google.com/file/d/1t_kpb1y-8ceAKNPyKtFS9vhpQgIbmBDf/view?usp=share_link

Really don't understand why the author doesn't come with a version, the bundling is trivial to do.

the download link is have a problem, this file is only 676Byte, and can not open