[Wanted feature] Request for `List Certificates` enhancement

[The-Lum]

This is a feature request.

Inspired by a screen of https://github.com/kaikramer/keystore-explorer/issues/375#issue-1281335966

Is your feature request related to a problem? Please describe. I'm always frustrated when I list certificates... I need sometime other fields, and want to filter or sort some fields...

Describe the solution you'd like For a future enhancement [on DListCertificatesKS.java], for the List Certificates screen perhaps adding:

• SKI (SUBJECT_KEY_IDENTIFIER)
• AKI (AUTHORITY_KEY_IDENTIFIER)

Then also: adding possibility to filter or sorting all the different fields...

See also similar pseudo-request here:

We could even filter and show only those that have been signed by the sub-AC, with which we are about to sign the CRL...

• https://github.com/kaikramer/keystore-explorer/pull/276#commitcomment-64120915

If that interest other people... or if someone can propose a PR.. about List Certificates screen... Regards.

[FYI @kaikramer, @jgrateron]

[jgrateron]

Hi, indeed more functionality is needed on that screen. I am going to take some time to make those adjustments.

Regards.

[jgrateron]

Hello It uses the same component to display the entries of a keystore, this component also allows sorting and its columns depend on general preferences.

https://github.com/jgrateron/keystore-explorer/tree/enhanceListCertificate

Filtering I don't think I will perform it.

[The-Lum]

Hello @jgrateron, and all,

Here are simple (and easy [Sorry!]) remarks:

1. Goods enhancement, futhermore that uniformise kse windows. :+1:
2. How to avoid to duplicate code? Is it possible to factorise the code of the main windows and the code of the sub windows... (unfortunately I am not a good java dev)...

Regards.

[jgrateron]

Hello @The-Lum If you mean refactoring the methods setColumnsToIconSize and colAdjust, yes it is possible. It only remains that @kaikramer gives his approval of the improvement.

Regards

[The-Lum]

If you mean refactoring the methods setColumnsToIconSize and colAdjust, yes it is possible. It only remains that @kaikramer gives his approval of the improvement.

Yes. @kaikramer: Are you agree, if will setColumnsToIconSize and colAdjust be factorised? Is it necessary to create a new public class for that or link/include to KseFrame.java and change the 2 method in order to be public...

---

https://github.com/kaikramer/keystore-explorer/blob/78cf949a26d1a5d17fbc04d15df4f7ed01ba2373/kse/src/org/kse/gui/KseFrame.java#L2445 And: https://github.com/jgrateron/keystore-explorer/blob/75d11485320a055fbba9102fe1bdc508dfc476a2/kse/src/org/kse/gui/dialogs/sign/JListCertificates.java#L142

---

https://github.com/kaikramer/keystore-explorer/blob/78cf949a26d1a5d17fbc04d15df4f7ed01ba2373/kse/src/org/kse/gui/KseFrame.java#L3141 And:

https://github.com/jgrateron/keystore-explorer/blob/75d11485320a055fbba9102fe1bdc508dfc476a2/kse/src/org/kse/gui/dialogs/sign/JListCertificates.java#L152

---

Regards.

[kaikramer]

refactoring the methods setColumnsToIconSize and colAdjust, yes it is possible. It only remains that @kaikramer gives his approval of the improvement.

Yes, of course, it is a very good idea to reuse the component.

[jgrateron]

Hi Refactoring of methods setColumnsToIconSize and colAdjust to class JKseTable completed.

Regards.

[The-Lum]

Hi @kaikramer, @jgrateron, and all,

Thanks for this enhancement (on v5.5.2). That is consistent in order to have the same screen as the main screen. But:

• Is it possible to resize (on the max.) this windows?
• and (especially) the columns? It is currently not possible.

See screenshot here (with red arrows):

In fact, the main question will be:

• What would be the minimum acceptable size (of the List Certificates windows)? depending or not on the contents of the table according to the preferences of the user...

---

• Is it necessary to open a new issue or not?

Thanks a lot. Regards, Th.

[kaikramer]

Hm, I see, it seems necessary to be able to enlarge the dialog now that we can have so many columns in this dialog...

What would be the minimum acceptable size (of the List Certificates windows)? depending or not on the contents of the table according to the preferences of the user...

Yes, good point, not sure if it is necessary to calculate the starting (or minimum) size... It seems like it should be quite a bit wider in your screenshot...

Is it necessary to open a new issue or not?

Yes, please, it helps me to keep an overview. It is fine if you keep it very short (just the screenshot and a headline).