Enhance find dialog - Githubissues

kaikramer / keystore-explorer

KeyStore Explorer is a free GUI replacement for the Java command-line utilities keytool and jarsigner.

https://keystore-explorer.org/

GNU General Public License v3.0

1.67k stars 271 forks source link

Enhance find dialog #380

Closed jgrateron closed 2 years ago

jgrateron commented 2 years ago

Hello.

Taking advantage of some free time, I can improve the search dialog.

What other fields can be added for evaluation?

Greetings.

enhancefinddialog

jgrateron commented 2 years ago

Hi.

I think it is ready, works better than expected.

The-Lum commented 2 years ago

Good,

And here is a new enhancement... For Algorithm:

Could we have a combobox instead free text?

And, perhaps also...

Could you add SKI / AKI?

Regards.

jgrateron commented 2 years ago

Thanks @The-Lum Update combobox in signature algorithm

SKI / AKI. for now I do not know how to locate them, I will investigate.

The-Lum commented 2 years ago

Thanks for signature algorithm; But what happens for other algo. like symmetric algo. (TDEA, AES, ...)?

To debate to know what are the best fields for searching enhancement...

kaikramer commented 2 years ago

This seems to be getting a bit complicated. For a good user experience it might be better to offer only a single search field that searches in all currently visible columns. For example: I want to find a certificate with a certain serial number that I have on the system clipboard. Then I can just do Ctrl-F, Ctrl-V and Enter.

The only problem with that is: Searches for multiple fields (e.g. for "IssuerDN" AND "SN") are not possible.

So maybe we could offer two versions of the search dialog: "simple search" and "advanced search".

jgrateron commented 2 years ago

Hello I made the adjustments to a simple search using the most important attributes (alias, algorithm, subjectCN, issuerCN, serial)