search

kaikramer / keystore-explorer

KeyStore Explorer is a free GUI replacement for the Java command-line utilities keytool and jarsigner.
https://keystore-explorer.org/
GNU General Public License v3.0
1.67k stars 271 forks source link

Enhance find dialog #381

Closed jgrateron closed 2 years ago

The-Lum commented 2 years ago

Just for traceability, this PR corresponds to:

kaikramer commented 2 years ago

Maybe there were some misunderstandings. My thoughts were:

  1. The first version of the new find dialog with several search fields was totally fine, but only as an alternative for the simple search. If you only have the complicated search, then this is a change for the worse for many users. The user should be able to choose between "simple" and "advanced" search. So there are 2 menu items "Find" and "Advanced Find" and two shortcuts (Ctrl-F and maybe Ctrl-Shift-F) and one shows a dialog with a single search field and the other this one: image

  2. The idea for the improved simple search dialog was: Search in all the data that is currently visible in the table (i.e. in all activated columns). Because it is confusing if the user searches for something and then keystore entries are selected and it is not clear why they are selected, because the matching field is not visible. This will look like a bug. In the code this means to call ApplicationSettings.getKeyStoreTableColumns() and search in the matching fields.

Please ask if something is not clear about this.