Closed Colbix closed 1 year ago
That's awesome! I love it
Created PR 395. The menu is using buttons but can be easily updated to use jmenuitems instead or even a jtree if desired. I refined some of the functions and added some regex parsing as well for the proxy settings.
I think the preference panels should be moved to their own class and possibly grouped under a new package, maybe org.kes.gui.dialog.preference, leaving the preference dialog to handle any checks and implement changes. I also added comments as TODO's for each panel although there is a good example of how a separate class, distinguishednamechooser, can be used inside the preference dialog.
The menu is using buttons but can be easily updated to use jmenuitems instead or even a jtree if desired.
Buttons would be fine, but highlighting the current selection looks a little bit awkward with buttons (s. my comment in the review).
I think the preference panels should be moved to their own class and possibly grouped under a new package,
Yes, they should be moved. This class has become pretty large.
I have one more update which I'll put in as a separate PR as the other was merged. The PR will primarily add dynamic width to each cell based on the font and text width. As seen in the pictures below trecells make use of label and will truncate text if text extends beyond the label's set width.
Static width, truncated text
Dynamic width, non-truncated text
I have a few other minor updates such as default selected row and consolidating the image icon and string refs into the menu class to maintain consistent arguments.
Is your feature request related to a problem? Please describe. The preferences menu currently displays a tabbed pane. The pane style will become more difficult to navigate and display additional features.
Describe the solution you'd like Create a vertical menu that can support additional user features as they are implemented.
Describe alternatives you've considered Continue to add additional tabs to the existing tabbed pane.
Additional context Add any other context or screenshots about the feature request here. I created a split pane to contain a navigation menu on the left and a cardlayout to contain the existing features and preferences on the right.