kaikramer / keystore-explorer

KeyStore Explorer is a free GUI replacement for the Java command-line utilities keytool and jarsigner.
https://keystore-explorer.org/
GNU General Public License v3.0
1.7k stars 275 forks source link

[GUI][i18n] Open question about label of number of revoked certs on CRL view #472

Closed The-Lum closed 10 months ago

The-Lum commented 10 months ago

Hello @kaikramer, and all,

During French translation improvement, I ask me some questions about label of number of revoked certs on CRL view:

And: https://github.com/kaikramer/keystore-explorer/blob/0e0507a5a313c613f5642c35d93f26e2194e0a60/kse/src/org/kse/gui/dialogs/resources.properties#L412

Instead of the current:

flowchart LR
C{ }
C -->|0| Z["Revoked Certificates (no entries):"]
C -->|1| O["Revoked Certificates (1 entry):"]
C -->|1<| M["Revoked Certificates (nn entries):"]

I would prefer this form:

flowchart LR
C{ }
C -->|0| Z["Empty CRL (no entries)."]
C -->|1| O["Only 1 revoked Certificate:"]
C -->|1<| M["nn revoked Certificates:"]

I can propose a PR to change in this way...

Regards, Th.

kaikramer commented 10 months ago

It might be a nice improvement. I am not sure what to think of the word "only" here, it adds some kind of assessment. Maybe just write the number 1 as a word instead? It would certainly help to see it in the context of the whole dialog.

The-Lum commented 10 months ago

Why not!

Maybe just write the number 1 as a word instead?

Then here is the corresponding proposal:

  1. "Empty CRL (no entries)."
  2. "One revoked Certificate:"
  3. "nn revoked Certificates:" or "Revoked Certificates (nn entries):"

Regards, Th.

kaikramer commented 10 months ago

Yes, it's fine for me