search

kaikramer / keystore-explorer

KeyStore Explorer is a free GUI replacement for the Java command-line utilities keytool and jarsigner.
https://keystore-explorer.org/
GNU General Public License v3.0
1.7k stars 275 forks source link

Fix Debian package lint warnings #513

Closed stokito closed 2 months ago

stokito commented 2 months ago

The gradle buildDeb produces the build/distributions/kse_all.deb package. You may open in in the gdebi GUI programs and open Linitan tab. It shows a lot of warnings and problems.

The first one is that the Section: Security doesn't exists i Debian. You may check the existing sections here https://packages.debian.org/stable/. So I changed it to Utils.

The package description in Debian should have not longer than 80 chars in a line.

Basically that all should be fixed in the gradle-ospackage-plugin but I don't really see any reason to use it at all. We can replace it with the Debian native debian folder.

stokito commented 2 months ago

Basically the whole gradle ospackage plugin lacks of many features. For example you can't specify the debian/copyright file.

It makes sense to use the plugin if you want to build RPM package on Win or Debian but generally it would be better to use native packaging tools. With the GitHub CI it shouldn't be a problem.

I'll add the debian folder to make it possible to build the KSE with debuild command. My end goal is to make it possible to include the KSE into official Debain repo or at least create an Ubuntu PPA or a custom repo.

Here is a draft branch that already build something but not fully working yet https://github.com/stokito/keystore-explorer/tree/debian

kaikramer commented 2 months ago

Basically the whole gradle ospackage plugin lacks of many features. For example you can't specify the debian/copyright file.

It makes sense to use the plugin if you want to build RPM package on Win or Debian but generally it would be better to use native packaging tools. With the GitHub CI it shouldn't be a problem.

Actually that's not the main reason for using this plugin. It allows to create both .deb and .rpm packages without really knowing how to do it. The result might not be perfect, but I simply don't have the time to learn all the details of using the native packaging tools for both Debian and RedHat based distributions.

I'll add the debian folder to make it possible to build the KSE with debuild command. My end goal is to make it possible to include the KSE into official Debain repo or at least create an Ubuntu PPA or a custom repo.

That would be great!