search

kaikramer / keystore-explorer

KeyStore Explorer is a free GUI replacement for the Java command-line utilities keytool and jarsigner.
https://keystore-explorer.org/
GNU General Public License v3.0
1.7k stars 275 forks source link

Enabled support for arm64. #517

Closed jonwltn closed 3 weeks ago

jonwltn commented 4 weeks ago

The JAR in this pull request is built from TheInfiniteKind/appbundler using JDK 1.8. TheInfiniteKind/appbundler has arm64 support since 2022.

Partially resolves #366.

This pull request enables support for arm64, but it is not a complete solution. If JAVA_HOME is pointing at an x86_64 JDK then the included JDK is x86_64. If JAVA_HOME is pointing at an arm64 JDK the the included JDK is arm64. This pull request will generate a fat binary for KeyStore Explorer, but it still requires two builds one for each architecture for the embedded JDK.

The build problem could be automated by having two different JAVA_HOME environments (e.g. JAVA_HOME_X64 and JAVA_HOME_ARM64), which would allow the build to generate two different disk images. Alternatively, the continuous integration job could be updated to call the build twice using different JDKs with no changes to the Gradle build.

jonwltn commented 4 weeks ago

I just saw your comment on my close pull request. I'll see about using the JAR from Maven central.

kaikramer commented 3 weeks ago

Thanks for the PR, appreciated!