search

kaikramer / keystore-explorer

KeyStore Explorer is a free GUI replacement for the Java command-line utilities keytool and jarsigner.
https://keystore-explorer.org/
GNU General Public License v3.0
1.68k stars 272 forks source link

add "Validity Start Date" #73

Closed mmariotti closed 7 years ago

mmariotti commented 7 years ago

Hello,

First of all I'd like to thank you for your great work, now I can finally handle keystores in a human way ;)

Commonly, I have to generate signed certificates/entries from my own CA, which must be valid from 20XX/01/01 00:00:00 to 20XY/01/01 00:00:00.

Java keytool allows to specify the start date: keytool -gencert -startdate "20XX/01/01 00:00:00" -validity "365" ...

I'm asking if you can add this field in "Sign CSR" (but it's also useful in "Generate Key Pair" and "Sign Key Pair").

Furthermore, I'd like to have a "Validity End Date" instead of "Validity Period".

Thank you!

kaikramer commented 7 years ago

Hi, sounds like a useful feature, although I personally don't need it. That keytool allows to set a start date is reason enough to implement this in KSE as well.

I don't think this feature will make it into 5.3, but maybe 5.4. Of course, a pull request could speed this up a lot. 😄

mmariotti commented 7 years ago

OK, I created the PR #74 👍

I replaced the 'validity period' fields and labels with JDateTime start and end date. The I updated the X509CertificateGenerator to take dates.

mmariotti commented 7 years ago

see PR #76