kailash-ratufa / csipsimple

Automatically exported from code.google.com/p/csipsimple
0 stars 0 forks source link

Android native integration + sign transformed into encoded uri sign #413

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Use "Call" command with Google Voice Search
2. Phone gets ready to dial # and asks whether to dial using a SIP or the 
Mobile number.
3. I press one of my SIP number's associated with Csipsimple and my phone 
Hangs-up before dialing with number format of +1XXXYYYZZZZ

What is the expected output? What do you see instead?
Expected output is for csipsimple to dial the phone #.
Instead, I see call in-progess and then Hung-up.

What version of the product are you using? On what operating system?
Nexus One (AT&T), MM's v2.12 Desire SuperHybrid/ ROM.

Please provide any additional information below.

Original issue reported on code.google.com by rautiala...@gmail.com on 24 Nov 2010 at 6:55

GoogleCodeExporter commented 9 years ago
Two possible cases. 
* it s a codec problem ( your sip provider does support only one codec that is 
not yet supported by csipsimple for example g729) 
* another possibility ( more probable according to the description) is that 
your sip provider does not support + sign in sip phones numbers ( it is the 
case of many providers). In this case there is a cool solution in csipsimple. 
Read the FAQ wiki page about rewriting rules. In your cases you may add a 
rewrite rule type " begin with" "+" "replace by" "00" (I guess it is 00 but 
should be confirmed by your sip provider documentation). Keep in mind that 
these rules only applies to the android integration. If you use csipsimple 
dialer, you must enter the number you want to be dialled ( but the most useful 
way to use csipsimple is to use the android integration -voice search is part 
of the integration, so in your case rewriting rule will apply :))

Original comment by r3gis...@gmail.com on 24 Nov 2010 at 7:11

GoogleCodeExporter commented 9 years ago
Thanks for fast reply, I'll try your suggested solutions and report back. I
use IPcomms as my Sip provider.
- rodney

that

that

the

but

Original comment by rautiala...@gmail.com on 24 Nov 2010 at 7:21

GoogleCodeExporter commented 9 years ago
Hop, just found a bug in testing (not directly related to this one..; or maybe 
yes... but I doesn't pass correctly the + sign if comes from native dialer).
I'll fix that asap, but the 00 workaround should works anyway ;).

Original comment by r3gis...@gmail.com on 24 Nov 2010 at 8:08

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
The 00 workaround worked! Thanks for the prompt support. Csipsimple is probably 
the best SIP client around.  I will donate.   

Original comment by rautiala...@gmail.com on 24 Nov 2010 at 8:35

GoogleCodeExporter commented 9 years ago
I'm not quite sure how to donate. I live in the US and when I click on donate I 
get redirected to a website in french with Euro's.

Original comment by rautiala...@gmail.com on 24 Nov 2010 at 8:48

GoogleCodeExporter commented 9 years ago
Mhh, I'm not a master of paypal. I've probably added the donate button in my 
language (I'm french).
But, don't bother with donation, reporting bugs and share your experience with 
other users is much more valuable for me ;).

I do the app just for my pleasure and my goal is just to make a nice app and 
create a community to develop, support and help to improve it ;).

I rename the bug to track the other bug I've detected this morning testing the 
issue.

Original comment by r3gis...@gmail.com on 24 Nov 2010 at 9:00

GoogleCodeExporter commented 9 years ago
I have tried replacing '+' Sign with '00' or '0' using customised filters and 
it is working fine. I just tried replacing '+' with blank, as one of my sip 
account don't work with '+' or '00'. How do I remove '+' from the phone no. I 
do not know about regexp. 

Original comment by edesk.pr...@gmail.com on 24 Nov 2010 at 10:33

GoogleCodeExporter commented 9 years ago
Mhh, I didn't think about this use case.. That's true you should be able to 
replace matching with blank. I'll remove this lock.
Meanwhile, you can indeed use regexp instead of replace matching with :
Just try in the last field to put :

$1

(It will replace the entire line with the matching 1 (which in begin with rule 
is everything except the begin with match)

Original comment by r3gis...@gmail.com on 24 Nov 2010 at 10:42

GoogleCodeExporter commented 9 years ago
Issue 418 has been merged into this issue.

Original comment by r3gis...@gmail.com on 24 Nov 2010 at 9:20

GoogleCodeExporter commented 9 years ago
Fixed in revision r373 . Will be available in next dev build.

Original comment by r3gis...@gmail.com on 24 Nov 2010 at 10:09

GoogleCodeExporter commented 9 years ago
Available in 0.00-15-15

Original comment by r3gis...@gmail.com on 24 Nov 2010 at 11:28