search

kailinteoo / pe

0 stars 0 forks source link

Bugs related to duplicate detection #3

Open kailinteoo opened 4 months ago

kailinteoo commented 4 months ago

Steps to reproduce:

  1. Enter "add id/E1234576 n/Jasper p/98765234 e/Jasper@example.com t/Student g/CS2103T"
  2. Save this contact number and appear in the contact panel

Expected: Error message or warnings will be thrown to me since the phone number i keyed in is the same for the other few students.

Actual: Able to save the student information without any issue

Reason: It will confuse the user when doing tracking list and wondering who they are contacting when calling the given number, is it Jasper? Kailin? or John?

Screenshot:

image.png image.png

nus-se-script commented 4 months ago

Team's Response

First of all, the intended behaviour written by the tester is not our intended behaviour and it is also not included in our UG and DG. The reason for giving freedom to user to edit the phone numbers is to provide them with the flexibility of editing number to whichever they want. In reality, it is possible that two people might share the same number (two of them are siblings/related and in a hypothetical situation here they both share one phone). Also, we feel that the confusion caused to the tester could be more of a documentation bug as we did not explicitly mention that the unique identifier is NUSID and it makes sense for it to be the unique identifier since it is school-based.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I understand the reasoning behind your team's perspective, and I do agree that multiple individuals might share the same phone number. However, I believe it would be beneficial to display a warning message for users when a significant number, say more than 10 individuals, input the same number, as it could potentially indicate a mistake.