search

kailinteoo / pe

0 stars 0 forks source link

Restricting the 8-digit phone number #5

Open kailinteoo opened 6 months ago

kailinteoo commented 6 months ago

Step:

  1. Enter " add id/E7654321 n/Betsy Crowe t/TA e/betsycrowe@example.com p/ 111133334444555" in the command panel.

Expected: Able to save the user information.

Actual: Error message "Phone numbers should only contain numbers, it should be between 3-10 digits long" is thrown to us instead.

Reason: Some phone number consist of more than 8 digits, especially in international contexts. Restricting phone numbers to only 8 digits could prevent users from inputting their complete phone numbers, leading to communication failures or inconvenience

Screenshot:

image.png

soc-pe-bot commented 6 months ago

Team's Response

It is reasonable for us, as developers, to have the understanding that all students, despite the fact that they could be international or exchange student, would hold a Singapore number for the purpose of contacting them locally in Singapore. For instance, if a staff from NUS wants to contact them, it would not be possible to reach them without a Singapore number if these students were to provide their original number. Therefore, our team decision was to cater for Singapore number of 8 digits, with 2 more digits for country code (65) , therefore the allowance of 8-10 digits in the PHONE_NUMBER field.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I understand your team point. If this is the case, I believe it is important to clarify in either the UG or the result display box that the phone number input is restricted to Singapore phone numbers. Also, the result display message indicate a range of 3-10 digits... it definitely misleading to the user that this application accept phone number that's not just Singapore number as it accept digit less than 8?

Overall, I accept your team point of view, but the result display box does not match the explanation that you all give. So, either the UG or the features of the application has an issue.

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]