search

kailynangelo / nbaStatsFun

Individual project for Enterprise Java class.
0 stars 0 forks source link

Code Review #5

Open shanda-matc opened 10 months ago

shanda-matc commented 10 months ago

Design/Code Review Project: InbaStatsFun Developer: Kailyn Angelo Reviewer: Shilpa Handa

Item Considerations Comments/Suggestions
Reviewer comments and suggestions go here. Each item should have at least one "kudos" and two suggestions for improvement
Problem Statement 1. Accurately describes project purpose
2. Is professional and free of typos, slang, etc.
3. Fully explains the problem and the solution
4. Is understandable by the average person		 1. The problem statement clearly describes the project purpose: providing NBA statistics. It is free of typos and slangs. It also explains the problem and it's solution and easy to understandable
Design Documentation 1. Navigation/flow through the application is logical and easy to use.
2. The order in which values are displayed are logical and easy to understand/use
3. The order in which the form fields entered are logical and easy to understand/use
4. All data discussed/documented (problem statement, flow, db design, etc.) is represented on the screens		 The design document is not complete. The one screen design looks good. The database design is missing.
Data model/Database 1. Everything on the screens and problem statement/flow is represented in the model
2. There is at least one 1-to-many relationship.
3. The model represents good database design		 There is no database model in the repository
Code 1. Proper Maven project structure is used
2. a .gitignore file for IntelliJ Java projects has been implemented
3. There is not any redundant or copy/paste code in the JSPs or classes
4. Classes are appropriately-sized (no monster classes)Property files are used appropriately: no hard-coded values
5. Logging statements are used rather than System.out.println and printStackTrace.
6. There are appropriate unit tests/code coverage.		 Proper Maven project structure is used and .gitignore is implemented.
pawaitemadisoncollege commented 10 months ago

Hi @shanda-matc! Thank you for your feedback on Kailyn's project so far. I noticed some categories above do not include suggestions for improvement. For example, did you review the repository for println statements and logging? What can you share about unit tests/code coverage?