Missing #include <cctype>

kainjow / Mustache

Mustache text templates for modern C++

Boost Software License 1.0

357 stars 49 forks source link

Missing #include <cctype> #29

Closed Quincunx271 closed 6 years ago

Quincunx271 commented 6 years ago

Mustache uses std::isspace, which lives in the cctype header (well, it uses isspace but should probably use std::isspace). This #include is missing, which means that Mustache fails to build on Visual Studio 2017.

kainjow commented 6 years ago

It's setup with AppVeyor for testing with 2013, 2015 and 2017. I wonder if this is a recent change in 2017. Could you make a pull request?

Quincunx271 commented 6 years ago

It may be a recent VS 2017 change, or maybe it's because of the /permissive- flag I'm passing to MSVC.

I'll go ahead and make a PR

kainjow commented 6 years ago

Ah yeah, that's probably it.