You should at least provide a short description. That would make the things easier to understand.
From what I see, that PR doesn't resolve the issue #3 . It only bypasses the exists() method for topics and subscriptions (and so it will reduce the number of calls to the google API). But if they ever get deleted (from the dashboard or any other script), the lib won't be able to re-create them until the cache expires. I'm ok with that, but it needs to be specified in the documentation and should be optional.
Regarding the code, it lacks test and there are other things that could be improved. I will suggest some improvement tomorrow (in case you want to use it in your fork). But sorry I don't think that such a feature is needed for now (and definitely not by default) so I will not merge it.
Hi,
You should at least provide a short description. That would make the things easier to understand.
From what I see, that PR doesn't resolve the issue #3 . It only bypasses the
exists()method for topics and subscriptions (and so it will reduce the number of calls to the google API). But if they ever get deleted (from the dashboard or any other script), the lib won't be able to re-create them until the cache expires. I'm ok with that, but it needs to be specified in the documentation and should be optional.Regarding the code, it lacks test and there are other things that could be improved. I will suggest some improvement tomorrow (in case you want to use it in your fork). But sorry I don't think that such a feature is needed for now (and definitely not by default) so I will not merge it.