search

kainxspirits / laravel-pubsub-queue

A Laravel queue driver for Google PubSub.
MIT License
45 stars 36 forks source link

Optional subscription and topic creation #35

Closed martianoff closed 4 years ago

martianoff commented 4 years ago

In high throughput system automatic creation of topic and subscriptions cause very high usage of "Administrator operations per minute" quota which is 6000 per minute and can't be increased (Google\Cloud\Core\Exception\ServiceException: { "error": { "code": 429, "message": "Quota exceeded for quota metric 'Administrator operations' and limit 'Administrator operations per minute' ... }. It makes driver unusable. Problem could be solved by disabling automatic creation, avoiding "exists" calls and manual creation of all queues and subscriptions in GCP

kainxspirits commented 4 years ago

Code wise, it looks ok to me. You can remove the two comments and I will merge it. Your code is pretty much self-explanatory so those comments are not needed.

I won't release it right away because a better approach would be to the automatic topic/subscription creation would be to implement some kind of retry policy when the request fails. I will work on it later this week, and release it along with that feature.

Thanks for the PR :)