kainxspirits / laravel-pubsub-queue

A Laravel queue driver for Google PubSub.
MIT License
45 stars 36 forks source link

Acknowledge or not should depend upon job processing result by default #55

Open qbaze opened 2 years ago

qbaze commented 2 years ago

At the moment it's not possible to take advantage of a builtin retry mechanism of a pubsub subscription (https://cloud.google.com/pubsub/docs/handling-failures) as messages are acknowledged as soon as they are successfully pulled (not processed) from a subscription.

Laravel retry mechanism (push back to topic) is BADLY designed imho at tleast when it comes to pubsub.

  1. requires an app to have publish permissions - VERY BAD
  2. as many subscribers can exist for a single topic pushing the same message again will cause other subscribers process the same message again - BAD