PHPUnit 10 Shift - Githubissues

kainxspirits / laravel-pubsub-queue

A Laravel queue driver for Google PubSub.

MIT License

45 stars 36 forks source link

PHPUnit 10 Shift #72

Closed kainxspirits closed 9 months ago

kainxspirits commented 9 months ago

This pull request contains changes for upgrading to PHPUnit 10 automated by the PHPUnit 10 Shift.

Before merging, you need to:

Checkout the shift-111318 branch
Review all pull request comments for additional changes
Run composer update (if the scripts fail, add --no-scripts)
Run your tests suite: vendor/bin/phpunit

If there were changes you felt could have been automated, please reply to the follow-up email with your feedback or on Twitter.

kainxspirits commented 9 months ago

:warning: PHPUnit 10 requires PHP version 8.1 or higher. Be sure to verify you met this requirement by running php -v in your test environment.

kainxspirits commented 9 months ago

:warning: PHPUnit 10 has made several changes to the configuration file. After running composer update, you may run vendor/bin/phpunit --migrate-configuration to have PHPUnit upgrade your configuration file.

kainxspirits commented 9 months ago

:x: The setMethods method on the MockBuilder was deprecated in PHPUnit 8 and removed in PHPUnit 10. Instead, you may use onlyMethods to mock methods which exist and addMethods to mock methods which do not exist.

Shift detected calls to setMethods in the following files:

[ ] tests/Unit/Jobs/PubSubJobTests.php
[ ] tests/Unit/PubSubQueueTests.php

kainxspirits commented 9 months ago

:information_source: PHPUnit has documented using return types for test cases and data providers since PHPUnit 8. In an effort to modernize your test suite, Shift added a return type of void to your test cases and a return type of array to your data providers.

Shift understands developers have different preferences when it comes to type hints. If you do not wish to add return types, you may undo this change by running: git revert 9598cd72

kainxspirits commented 9 months ago

:information_source: PHPUnit has documented declaring test classes as final since PHPUnit 8. In an effort to modernize your test suite, Shift has declared your test classes as final.

Shift understands developers have different preferences when it comes to using final. If you do not wish to declare your test classes as final, you may undo this change by running: git revert 48235b26

kainxspirits commented 9 months ago

:warning: PHPUnit 10 now requires any base test class to have a TestCase suffix. In addition, this class should be defined as abstract. If you have a custom base test class, you should ensure it meets these new requirements.

kainxspirits commented 9 months ago

:alembic: This Shift is still being refined. Please report any issues or suggestions to shift@laravelshift.com. Your feedback is what helps improve the experience for everyone.