kaiotcp1 / ARMA3-SCRIPTS

0 stars 0 forks source link

Code Suggestions #1

Open hypoxia125 opened 10 months ago

hypoxia125 commented 10 months ago

Since you linked your project in the Arma discord, I'll show you some stuff:

Use of Params

Stuff like this:

_roadBlockInfo = _x;
_markerNameForDelete = _roadBlockInfo select 0;
_grupoSoldadosForVerify = _roadBlockInfo select 1;
_objectForDelete = _roadBlockInfo select 2;

Can become:

_x params ["_markerNameForDelete", "_grupoSoldadosForVerify", "_objectForDelete"];

https://github.com/kaiotcp1/ARMA3-SCRIPTS/blob/3e034822784fd7ba7b682623042636ea614efdf7/rb/rbbuild.sqf#L72C1-L74C47 https://github.com/kaiotcp1/ARMA3-SCRIPTS/blob/3e034822784fd7ba7b682623042636ea614efdf7/rb/rbbuild.sqf#L115C1-L118C46

Use of Private

When declaring local variables (_myVar), you should use private when applicable.

_enableScript = true;
_obj = [];
_roadBlocksAtivos = [];
_pos = [];
_direction = [];
_triggerData = [];

To

private _enableScript = true;
private _obj = [];
private _roadBlocksAtivos = [];
private _pos = [];
private _direction = [];
private _triggerData = [];

This applies to code inside of your forEach blocks as well that you want to keep only to that scope.

https://github.com/kaiotcp1/ARMA3-SCRIPTS/blob/3e034822784fd7ba7b682623042636ea614efdf7/rb/rbbuild.sqf#L3C1-L8C19

kaiotcp1 commented 10 months ago

Thanks for the tips, I'll update in the next commits