kairoaraujo / goca

Golang Certificate Authority (CA) package

MIT License

38 stars 14 forks source link

Bump Go lang version to 1.17 #13

Closed kairoaraujo closed 1 year ago

kairoaraujo commented 2 years ago

This commit bumps the Go lang version to 1.17.

Signed-off-by: Kairo de Araujo kairo@kairo.eti.br

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@3defbda). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage        ?   65.94%           
=======================================
  Files           ?        2           
  Lines           ?      323           
  Branches        ?        0           
=======================================
  Hits            ?      213           
  Misses          ?       69           
  Partials        ?       41

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3defbda...7c1b502. Read the comment docs.

kairoaraujo commented 2 years ago

@necheffa could you please review it?

necheffa commented 2 years ago

@kairoaraujo it looks like the push to main knocked out the last couple pull requests and reverted to tip of main to where it was about a year and a half ago.

I am assuming this was not intentional.

kairoaraujo commented 2 years ago

Sorry, where do you see it? I only see changing the Go version, dependencies versions, and a wrong documentation test.

necheffa commented 2 years ago

@kairoaraujo take a look at this diff: https://github.com/kairoaraujo/goca/compare/8e931bba88f134913c7644b6a076eb98e10990df..61657ee1dbe73f70e98b2edd03e6d63301f5ea22

8e931bba88f134913c7644b6a076eb98e10990df is the commit from PR #10 getting merged and 61657ee1dbe73f70e98b2edd03e6d63301f5ea22 is the latest commit on this PR.

It looks like PR #9, #7, and #10 are missing.

The current tip of main according to GitHub is 3defbda95817771f0c41f23b410011d6cae5b5f1 which is from Feb 17 2021.

As far as the scope of change in this PR, I am ready to sign off but IMO it makes sense to rebase this PR off a commit that includes PR #9, #7, and #10 so that any conflicts/testing issues get resolved as part of this PR. If we try to add those PRs back later it could get ugly.

Let me know how you wish to proceed.