search

kairoaraujo / goca

Golang Certificate Authority (CA) package
MIT License
38 stars 14 forks source link

Release support to 1.21.x #28

Closed kairoaraujo closed 7 months ago

kairoaraujo commented 1 year ago

Signed-off-by: Kairo Araujo kairo@kairo.eti.br

codecov-commenter commented 7 months ago

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (8e931bb) 65.94% compared to head (940c632) 56.08%. Report is 24 commits behind head on main.

Files Patch % Lines
ca.go 65.09% 23 Missing and 14 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #28 +/- ## ========================================== - Coverage 65.94% 56.08% -9.86% ========================================== Files 2 2 Lines 323 460 +137 ========================================== + Hits 213 258 +45 - Misses 69 163 +94 + Partials 41 39 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kairoaraujo commented 7 months ago

@necheffa, "Better late than never"

I think due the changes, we should release as 2.0.0, WDYT?

necheffa commented 7 months ago

@kairoaraujo I think bumping to 2.0.0 makes sense. Looks like the API changed just a little. Should we then also add "v2" to the module path so that github.com/kairoaraujo/goca becomes github.com/kairoaraujo/goca/v2?