search

kairoaraujo / goca

Golang Certificate Authority (CA) package
MIT License
40 stars 13 forks source link

unbreak swaggo doc generation for Identity object #37

Closed dinghram closed 5 months ago

dinghram commented 6 months ago

The implementation that enabled IP addresses in certificate alternative names added an example that broke swaggo doc generation. This PR removes the example, which should allow swaggo to generate docs for the Identity object.

necheffa commented 5 months ago

It looks like since a new field was added to goca.Identity the reference output for swagger documentation also needs updated to prevent make from kicking back a non-success return to the shell (probably will make the pipeline unhappy).

Reference docs are doc/swagger.json and doc/swagger.yaml. I would think checking in a copy of the new generated docs would be sufficient to button this up.

dinghram commented 5 months ago

It looks like since a new field was added to goca.Identity the reference output for swagger documentation also needs updated to prevent make from kicking back a non-success return to the shell (probably will make the pipeline unhappy).

Reference docs are doc/swagger.json and doc/swagger.yaml. I would think checking in a copy of the new generated docs would be sufficient to button this up.

I've checked in a fix, I hope it is what you are looking for.