search

kairoaraujo / kodak-smart-home

Kodak Smart Home integration for Home Assistant
Apache License 2.0
7 stars 3 forks source link

Add support for Australia #4

Closed mfav01 closed 2 years ago

mfav01 commented 3 years ago

I was wondering if it would be possible to please add support for Australia?

I am really hoping to get this to work as it would be a great integration.

Thanks, Mark

kairoaraujo commented 3 years ago

Hi @mfav01 Mark,

Are you familiar with Python code? Maybe you could create a Pull Request after testing by yourself. I would be happy to receive this Pull Request.

It needs to be done here: https://github.com/kairoaraujo/python-kodaksmarthome/blob/master/kodaksmarthome/constants.py

See a similar PR (https://github.com/kairoaraujo/python-kodaksmarthome/pull/20)

mfav01 commented 3 years ago

Thanks @kairoaraujo.
I have attempted to edit the code, I am just working out how to run the tests. I have not used GitHub or tested code in HA before. I will submit the pull request once tested. https://github.com/mfav01/python-kodaksmarthome/blob/au-support_a01/kodaksmarthome/constants.py

kairoaraujo commented 2 years ago

Hi @mfav01, how was your test with AU support? Did it work out?

xlr82xs commented 2 years ago

Australia uses the same configuration as IN currently.

mfav01 commented 2 years ago

Hi all, thank you for your help. I can confirm Australia is working using the IN configuration. @kairoaraujo appreciate your work on this component.

Hopefully live streaming will also be possible soon.