kairos-io / kairos

:penguin: The immutable Linux meta-distribution for edge Kubernetes.
https://kairos.io
Apache License 2.0
1.13k stars 97 forks source link

🤖 Release needs to be triggered multiple times because we hit an API limit #1766

Open mauromorales opened 1 year ago

mauromorales commented 1 year ago

Not that we moved the building of the standard images to this repository, we constantly hit the following error on release

⚠️ Unexpected error fetching GitHub release for tag refs/tags/v2.4.0-alpha3: HttpError: API rate limit exceeded for installation ID 29320181.
Error: API rate limit exceeded for installation ID 29320181.

Maybe we should serialize and build core images first and only until those are done, build standard ones, and potentially those also in batches by k3s versions

mauromorales commented 1 year ago

Seems to be an error from the action https://github.com/softprops/action-gh-release/issues/52

mauromorales commented 1 year ago

Shoot if it's not an issue it's another :P

Run softprops/action-gh-release@v1
♻️ Deleting previously uploaded asset IMAGE...
⬆️ Uploading kairos-core-rockylinux-amd64-generic-v2.4.0-alpha4-grype.json...
⬆️ Uploading kairos-core-rockylinux-amd64-generic-v2.4.0-alpha4-grype.sarif...
⬆️ Uploading kairos-core-rockylinux-amd64-generic-v2.4.0-alpha4-initrd...
⬆️ Uploading kairos-core-rockylinux-amd64-generic-v2.4.0-alpha4-ipxe-usb.img...
⬆️ Uploading kairos-core-rockylinux-amd64-generic-v2.4.0-alpha4-ipxe.iso...
⬆️ Uploading kairos-core-rockylinux-amd64-generic-v2.4.0-alpha4-kernel...
⬆️ Uploading kairos-core-rockylinux-amd64-generic-v2.4.0-alpha4-sbom.spdx.json...
⬆️ Uploading kairos-core-rockylinux-amd64-generic-v2.4.0-alpha4-sbom.syft.json...
⬆️ Uploading kairos-core-rockylinux-amd64-generic-v2.4.0-alpha4-trivy.html...
⬆️ Uploading kairos-core-rockylinux-amd64-generic-v2.4.0-alpha4-trivy.json...
⬆️ Uploading kairos-core-rockylinux-amd64-generic-v2.4.0-alpha4-trivy.sarif...
⬆️ Uploading kairos-core-rockylinux-amd64-generic-v2.4.0-alpha4.ipxe...
⬆️ Uploading kairos-core-rockylinux-amd64-generic-v2.4.0-alpha4.iso...
⬆️ Uploading kairos-core-rockylinux-amd64-generic-v2.4.0-alpha4.iso.sha256...
⬆️ Uploading kairos-core-rockylinux-amd64-generic-v2.4.0-alpha4.iso.sha256.pem...
⬆️ Uploading kairos-core-rockylinux-amd64-generic-v2.4.0-alpha4.iso.sha256.sig...
⬆️ Uploading kairos-core-rockylinux-amd64-generic-v2.4.0-alpha4.squashfs...
♻️ Deleting previously uploaded asset VERSION...
⬆️ Uploading versions.yaml...
⬆️ Uploading VERSION...
Error: Failed to upload release asset versions.yaml. received status code 422
Validation Failed
[{"resource":"ReleaseAsset","code":"already_exists","field":"name"}]

All those versions.yaml and VERSION files, which don't follow the naming convention should not be uploaded

mauromorales commented 1 year ago

Unfortunately I cannot test the latest changes because of CI

mauromorales commented 1 year ago

we still hit the limit, i think we have way too many artifacts per release now ~650, plus all the uploads of trivy scans and such also count including the ones in master

master: https://github.com/kairos-io/kairos/actions/runs/6037668564/job/16382415974

release: https://github.com/kairos-io/kairos/actions/runs/6037175360/job/16380933584

mauromorales commented 1 year ago

which means all actions using this api can fail, in the case of the scans: github/codeql-action/upload-sarif@v2

Itxaka commented 1 year ago

Same thing here, we should probably have a checker in the job that checks for the API limit before starting the upload so we dont have to retry the whole thing.

So we can probably check some release endpoint and continue once we get a 200 response and wait if we have any other

Unexpected error fetching GitHub release for tag refs/tags/v2.4.0-rc1: HttpError: API rate limit exceeded for installation ID 29320181. If you reach out to GitHub Support for help, please include the request ID 0440:318B:2BBA09F:58EB3EA:64FB4020.
Error: API rate limit exceeded for installation ID 29320181. If you reach out to GitHub Support for help, please include the request ID 0440:318B:2BBA09F:58EB3EA:64FB4020.
jimmykarily commented 11 months ago

Doesn't happen lately. I'll close until we face this again.

mauromorales commented 11 months ago

seems to still be an issue:

API rate limit exceeded for installation ID 29320181. If you reach out to GitHub Support for help, please include the request ID 20B1:7A02:300522:3AF930:656EF6B9.

from https://github.com/kairos-io/kairos/actions/runs/7098645947/job/19321235606