search

kairos-io / kairos

:penguin: The immutable Linux meta-distribution for edge Kubernetes.
https://kairos.io
Apache License 2.0
1.02k stars 89 forks source link

Auroraboot should respect the livecd cmdline #2573

Open jimmykarily opened 1 month ago

jimmykarily commented 1 month ago

The original issue is with selinux: https://github.com/kairos-io/kairos/issues/2553 but it could happens with other options too. Instead of Auroraboot passing a hardcoded cmdline, it should instead use the one defined in the grub-config luet package to stay in sync with the livecd.

ci-robbot commented 1 month ago

Hello, I'm an experimental bot created by @mudler and @jimmykarily. I'm here to help audit Github issues according to the project's guidelines.

I noticed that you've opened an issue regarding Auroraboot not respecting the livecd command line. The issue seems to be related to the selinux problem, but it might also occur with other options. You suggest that Auroraboot should use the command line defined in the grub-config luet package instead of the hardcoded one.

However, the issue does not meet the project's requirements for a clear description of the problem and steps to reproduce, nor does it mention the versions of the relevant artifacts being used. To proceed, please provide a clear and concise description of the problem, along with steps to reproduce, if applicable. Additionally, please mention the versions of the artifacts you're using.

Once this information is provided, the issue will be labeled as 'triage' to indicate it has been reviewed and meet the project's guidelines. Thank you for your contribution, and please feel free to reach out if you have any further questions.

mauromorales commented 1 month ago

@jimmykarily how is the mapping between auroraboot and the luet package supposed to happen? I'm thinking about compatibility issues between Kairos versions. Maybe Auroraboot should have a way to tell which Kairos version and from there we know which cmdline or so?

jimmykarily commented 1 month ago

@Itxaka suggested this and I think he meant that Auroraboot should download the (latest?) luet package and find the cmdline there. Matching versions would also be nice but I don't know how easy that is. Feel free to play with options, it's not fully defined yet.

Itxaka commented 1 month ago

@Itxaka suggested this and I think he meant that Auroraboot should download the (latest?) luet package and find the cmdline there. Matching versions would also be nice but I don't know how easy that is. Feel free to play with options, it's not fully defined yet.

We should indeed either use the luet package to get the grub cdlive package and use that as base (so its synced between our isos and aurora ipxe boot, or we can extract the grub from the livecd directly if we are using that (iso-info maybe? loop mounts?)