search

kairos-io / kairos

:penguin: The immutable Linux meta-distribution for edge Kubernetes.
https://kairos.io
Apache License 2.0
1.09k stars 97 forks source link

Identify system by other keys when installing grub #2895

Open Itxaka opened 1 week ago

Itxaka commented 1 week ago

https://github.com/kairos-io/kairos-agent/blob/main/pkg/utils/grub.go#L214C40-L214C46

We use the KAIROS_FLAVOR key from os-release to try to identify if the image is an ubuntu one, as under EFI we need a workaround for ubuntu only.

But if we are using a source image for the install that its the upstream image directly, our kairos keys will not be there.

Ideally if the process is correct, the kairos keys should be there, as that means the image went through the kairos factory. But if thats not the case, the install still goes ok but you end up with a non booting system.

We should at least try to use other stuff in the os-release to identify the ubuntu machine (ID or ID_LIKE) to apply the workaround so we dont leave a broken system around.

Itxaka commented 2 days ago

This done, will be part of 3.2.1

Follow up is https://github.com/kairos-io/kairos/issues/2907

mudler commented 20 hours ago

we need a new version of the framework with the agent still, right?

mudler commented 19 hours ago

keeping it open until we have a framework image merged into kairos addressing this

Itxaka commented 19 hours ago

yes, stupid autoclose