search

kairosdb / kairosdb-client

Java Client for KairosDB
65 stars 67 forks source link

Update Client.java #4

Closed euforia closed 11 years ago

euforia commented 11 years ago

this is fix for /api/v1/tagNames. should be /api/v1/tagnames

jsabin commented 11 years ago

Merged it. Thanks for catching and fixing this.

On Fri, May 3, 2013 at 3:20 PM, euforia notifications@github.com wrote:

this is fix for /api/v1/tagNames. should be /api/v1/tagnames

You can merge this Pull Request by running

git pull https://github.com/euforia/kairosdb-client patch-1

Or view, comment on, or merge it at:

https://github.com/proofpoint/kairosdb-client/pull/4 Commit Summary

  • Update Client.java

File Changes

  • M src/main/java/org/kairosdb/client/Client.javahttps://github.com/proofpoint/kairosdb-client/pull/4/files#diff-0(4)

Patch Links:

euforia commented 11 years ago

Hey Jeff, Not sure if this is an issue so I figured I'd ask first to make sure I'm not going crazy.

I have the following query:

{ 'metrics': [{ 'name': 'some.metric', 'tags': { 'host': [ 'hostA', 'hostB' ] }, }], 'cache_time': 0, 'start_relative: { 'unit': 'hours', 'value': 2 }, }

If a string is supplied for the value of metrics[i].tags.host the query is successful and returns a result as expected. But supplying an array for the 'host' tag gives me the following error:

java.lang.IllegalStateException: Expected STRING but was BEGIN_ARRAY

Am I doing something fundamentally wrong or is this a bug? Please let me know.

cheers, abs

On Fri, May 3, 2013 at 5:47 PM, Jeff Sabin notifications@github.com wrote:

Merged it. Thanks for catching and fixing this.

On Fri, May 3, 2013 at 3:20 PM, euforia notifications@github.com wrote:

this is fix for /api/v1/tagNames. should be /api/v1/tagnames

You can merge this Pull Request by running

git pull https://github.com/euforia/kairosdb-client patch-1

Or view, comment on, or merge it at:

https://github.com/proofpoint/kairosdb-client/pull/4 Commit Summary

  • Update Client.java

File Changes

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/proofpoint/kairosdb-client/pull/4#issuecomment-17420114 .

cheers -abs

brianhks commented 11 years ago

You need to be using the beta 2 code for that to work.

euforia commented 11 years ago

thx brian.

On Mon, May 20, 2013 at 12:30 PM, Brian Hawkins notifications@github.comwrote:

You need to be using the beta 2 code for that to work.

— Reply to this email directly or view it on GitHubhttps://github.com/proofpoint/kairosdb-client/pull/4#issuecomment-18157176 .

cheers -abs

jsabin commented 11 years ago

Using an array was introduced in Beta 2. My guess you are using Beta 1.

Jeff

On Mon, May 20, 2013 at 9:54 AM, euforia notifications@github.com wrote:

Hey Jeff, Not sure if this is an issue so I figured I'd ask first to make sure I'm not going crazy.

I have the following query:

{ 'metrics': [{ 'name': 'some.metric', 'tags': { 'host': [ 'hostA', 'hostB' ] }, }], 'cache_time': 0, 'start_relative: { 'unit': 'hours', 'value': 2 }, }

If a string is supplied for the value of metrics[i].tags.host the query is successful and returns a result as expected. But supplying an array for the 'host' tag gives me the following error:

java.lang.IllegalStateException: Expected STRING but was BEGIN_ARRAY

Am I doing something fundamentally wrong or is this a bug? Please let me know.

cheers, abs

On Fri, May 3, 2013 at 5:47 PM, Jeff Sabin notifications@github.com wrote:

Merged it. Thanks for catching and fixing this.

On Fri, May 3, 2013 at 3:20 PM, euforia notifications@github.com wrote:

this is fix for /api/v1/tagNames. should be /api/v1/tagnames

You can merge this Pull Request by running

git pull https://github.com/euforia/kairosdb-client patch-1

Or view, comment on, or merge it at:

https://github.com/proofpoint/kairosdb-client/pull/4 Commit Summary

  • Update Client.java

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub< https://github.com/proofpoint/kairosdb-client/pull/4#issuecomment-17420114>

.

cheers -abs

— Reply to this email directly or view it on GitHubhttps://github.com/proofpoint/kairosdb-client/pull/4#issuecomment-18155164 .

euforia commented 11 years ago

Thx Jeff. Brian mentioned the same thing.

cheers, abs

On May 20, 2013, at 13:21, Jeff Sabin notifications@github.com wrote:

Using an array was introduced in Beta 2. My guess you are using Beta 1.

Jeff

On Mon, May 20, 2013 at 9:54 AM, euforia notifications@github.com wrote:

Hey Jeff, Not sure if this is an issue so I figured I'd ask first to make sure I'm not going crazy.

I have the following query:

{ 'metrics': [{ 'name': 'some.metric', 'tags': { 'host': [ 'hostA', 'hostB' ] }, }], 'cache_time': 0, 'start_relative: { 'unit': 'hours', 'value': 2 }, }

If a string is supplied for the value of metrics[i].tags.host the query is successful and returns a result as expected. But supplying an array for the 'host' tag gives me the following error:

java.lang.IllegalStateException: Expected STRING but was BEGIN_ARRAY

Am I doing something fundamentally wrong or is this a bug? Please let me know.

cheers, abs

On Fri, May 3, 2013 at 5:47 PM, Jeff Sabin notifications@github.com wrote:

Merged it. Thanks for catching and fixing this.

On Fri, May 3, 2013 at 3:20 PM, euforia notifications@github.com wrote:

this is fix for /api/v1/tagNames. should be /api/v1/tagnames

You can merge this Pull Request by running

git pull https://github.com/euforia/kairosdb-client patch-1

Or view, comment on, or merge it at:

https://github.com/proofpoint/kairosdb-client/pull/4 Commit Summary

  • Update Client.java

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub< https://github.com/proofpoint/kairosdb-client/pull/4#issuecomment-17420114>

.

cheers -abs

— Reply to this email directly or view it on GitHubhttps://github.com/proofpoint/kairosdb-client/pull/4#issuecomment-18155164 .

— Reply to this email directly or view it on GitHub.