search

kairosdb / kairosdb-client

Java Client for KairosDB
65 stars 69 forks source link

Upgrade the dependency to Kairos to 1.2.0 #69

Closed martin-g closed 6 years ago

martin-g commented 6 years ago

At the moment the client depends on Kairos 1.1.3. Would it be OK to upgrade it to 1.2.0 ?

martin-g commented 6 years ago

I am not sure whether it is related or not but I've got some of those in production:

ERROR 05/04 18:04:55.003 - com.example.KairosdbClient - Cannot send to KairosDB
com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was STRING at line 1 column 1
    at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:176)
    at com.google.gson.Gson.fromJson(Gson.java:803)
    at com.google.gson.Gson.fromJson(Gson.java:768)
    at org.kairosdb.client.JsonMapper.fromJson(JsonMapper.java:27)
    at org.kairosdb.client.AbstractClient.getResponse(AbstractClient.java:131)
    at org.kairosdb.client.AbstractClient.pushMetrics(AbstractClient.java:89)
    ...

I.e. Kairos client sends the request but fails while parsing the response, actually when checking for errors.

I cannot reproduce it locally though. Kairos client: 2.2.0 Kairos Server: 1.2.1

jsabin commented 6 years ago

Changed the version of Kairos to 1.2.1.