nus-se-bot
commented
2 years ago Team's Response
A duplicate of #1103. To reiterate our point:
We decided to not validate meeting link and this is a design decision. From an implementation perspective, checking whether a link is valid or not requires a lot of time resources and it would make our program unnecessarily slow. Furthermore, there exists non-standard URL format. To add on this, our program actually validate whether the input link is of www or http, and they will be automatically replace with https. This implementation has two benefits such as portability and security.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Lesson link not validated
Nonsense meeting url:
Since there's no check for url, the following occurs
[original: nus-cs2113-AY2122S1/pe-interim#1078] [original labels: severity.Medium type.FunctionalityBug]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
We decided to not validate meeting link and this is a design decision. From an implementation perspective, checking whether a link is valid or not requires a lot of time resources and it would make our program unnecessarily slow. Furthermore, there exists non-standard URL format. To add on this, our program actually validate whether the input link is of
wwworhttp, and they will be automatically replace withhttps. This implementation has two benefits such as portability and security.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
:question: Issue response
Team chose [response.Rejected]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
As seen in the screenshot above, the meeting URL "exit" is accepted. This should not be allowed since meeting URL should only be starting with "http" or "https" or "www".