search

kaisellgren / mailer

Compose and send emails from Dart. Supports file attachments, HTML emails and multiple transport methods.
MIT License
166 stars 86 forks source link

readme false advertising #238

Open fersegundo2 opened 11 months ago

fersegundo2 commented 11 months ago

The readme leads to believe that it is possible to send an email from flutter using code by JohannesMilke. This is from my point of view not true or at least very inaccurate. What most users would want to do and would assume by the readme that is possible is: use case 1 - send an email from the developers email to any other email use case 2- send an email from the email of the app user to any other user

use case 1 is not possible because the end app user is not the developer (so the developer cannot authenticate) and we cannot save the authentication token (mostly for security reasons as stated in the readme, but also because it expires after 1 hour) use case 2 is possible ONLY if we add the users email as "test user" in google cloud OAuth consent screen. Which obviously is not what we want because: 1) we want this feature to work in production mode 2) we cannot add all future users as "test users"

So from what I understand this library can be used from flutter only for testing/developer logging. Please specify this in the readme

close2 commented 10 months ago

@fersegundo2 I haven't tested the tutorial, but I thought that use case 2 is possible:

use case 2 should be possible: https://youtu.be/RDwst9icjAY?t=834

The test users should only be necessary in testing mode.

Am I mistaken?

bsutton commented 8 months ago

I don't think this is a case of false advertising just a matter of assumptions about the reader's knowledge.

The doco clearly talks about SMTP which to an experienced dev makes it obvious what the package is about.

Having said that, some explicit wording around the fact that it's an SMTP client will help out newbies.