search

kaiserbh / tachiyomi

Free and open source manga reader for Android.
https://tachiyomi.org/
Apache License 2.0
4 stars 3 forks source link

fix: update categories when merge #10

Closed Cologler closed 5 months ago

Cologler commented 5 months ago

Closes #8

Cologler commented 5 months ago

Another question:

Since restore only uses url and source as key:

https://github.com/kaiserbh/tachiyomi/blob/cb10b06ac281ced5c140e85f13f90485a2407923/app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt#L109-L111

Why does merge use title and author as key?

https://github.com/kaiserbh/tachiyomi/blob/cb10b06ac281ced5c140e85f13f90485a2407923/app/src/main/java/eu/kanade/tachiyomi/data/sync/service/SyncService.kt#L101-L103

Cologler commented 5 months ago

@kaiserbh

kaiserbh commented 5 months ago

Another question:

Since restore only uses url and source as key:

https://github.com/kaiserbh/tachiyomi/blob/cb10b06ac281ced5c140e85f13f90485a2407923/app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt#L109-L111

Why does merge use title and author as key?

https://github.com/kaiserbh/tachiyomi/blob/cb10b06ac281ced5c140e85f13f90485a2407923/app/src/main/java/eu/kanade/tachiyomi/data/sync/service/SyncService.kt#L101-L103

At some point, I thought some manga was being removed because of false positive, like it's getting the wrong data, so I made the composite key just to make sure the right manga is getting removed, etc. But well, it turns out it wasn't that, so we can just use the url and source. We should probably change that. @Cologler