search

kaishin / Gifu

High-performance animated GIF support for iOS in Swift
Other
3.09k stars 279 forks source link

CFBundleShortVersionString being set to last tag in parent repository while building with Carthage #157

Closed lukkas closed 4 years ago

lukkas commented 4 years ago

Currently, due to Set Version Number (I assume) build phase, problem may occur with Carthage builds.

When Gifu is put to Carthage's Checkouts directory and then built, its Git repository is the one of project, that builds Gifu as its dependency. Therefore Gifu package ends up with CFBundleShortVersionString being set to last tag of containing project, rather than Gifu's actual version.

For me it went unnoticed for a long time, but recently, due to tag format that doesn't match AppStore requirements for bundle version, my built was rejected.

kaishin commented 4 years ago

I am very sorry to hear that. I will remove the Set Version Number in a future release.

AvdLee commented 4 years ago

I opened a PR fixing this!