Fix performance issue related to word count

kaishin / markoff

A lightweight Markdown (CommonMark) previewer for macOS.

ISC License

793 stars 43 forks source link

Fix performance issue related to word count #15

Closed kaishin closed 8 years ago

kaishin commented 8 years ago

This PR fixes #5 by replacing the word counting code with something that requires less string manipulation. I also dropped the binary in favor of the actual cmark source using SwiftMark.

calleluks commented 8 years ago

This looks good to me!

klaaspieter commented 8 years ago

Apart from this appearing to be two separate changes (replacing the parser and fixing the word count) looks good to me.

NSTask loses again.

kaishin commented 8 years ago

@klaaspieter Yes, aware of the 2-in-1, but it was part of the debugging process :( I will keep the commits separate and save time by using one PR.