kaishin / markoff

A lightweight Markdown (CommonMark) previewer for macOS.
ISC License
793 stars 43 forks source link

App cannot print #8

Open sma opened 8 years ago

sma commented 8 years ago

If I try to print a document (to create a PDF document), this alert occurs: image

kaishin commented 8 years ago

This seems like a reasonable thing to add to a Markdown previewing app.

dmnsk commented 8 years ago

Missing this option, too.

balthisar commented 8 years ago

Oops... that's an easy oversight in Markoff.entitlements; I've done it myself. Hopefully @thoughtbot can take care of this.

kaishin commented 8 years ago

@balthisar Can you open a PR? I've been the only maintainer of this and can appreciate any help I can get here.

balthisar commented 8 years ago

Added #20 by request, and while this addresses the alert mentioned above and enables the print dialogue box, printing is still broken, at least on my system. Caveat: the system I have handy right now is 10.10.5 and I had to change the API target; you might want to test this on El Capitan (I will do so tonight), but in general there's nothing about the printing system that should preclude 10.10.5.

If printing is still broken, sorry. I've not spent any time with Swift yet. In Objective-C I might try [NSPrintOperation printOperationWithView:printInfo:]

kaishin commented 8 years ago

@balthisar Thanks for opening the PR! I can take a closer look after merging it.

joelpresence commented 7 years ago

Please see https://github.com/thoughtbot/Markoff/issues/39

It's actually more severe a bug than this: not only can the app not print, but it hangs and beachballs every time when you try to do so ...

@thoughtbot-hub @thoughtbot-learn @thoughtbot-learn-staging do you have an ETA for a fix?

Thanks!

iwill commented 6 years ago

Still cannot print :(

ankerstal commented 6 years ago

I want to print!! Please fix this!